diff --git a/src/main/java/osm/surveyor/task/city/TaskController.java b/src/main/java/osm/surveyor/task/city/TaskController.java
index c03cfa1..93973a0 100644
--- a/src/main/java/osm/surveyor/task/city/TaskController.java
+++ b/src/main/java/osm/surveyor/task/city/TaskController.java
@@ -67,186 +67,80 @@
model.addAttribute("tasks", tasks);
return "tasks";
}
-
- /**
- * 「予約登録」
- * @param user
- * @param model
- * @param citycode
- * @param meshcode
- * @return
- */
- @GetMapping("/task/reserve")
- public String reserve(@AuthenticationPrincipal UserDetails user,
- Model model,
- @RequestParam(name="citycode") String citycode,
- @RequestParam(name="meshcode") String meshcode)
- {
- model.addAttribute("command", "タスク登録");
-
- // ログイン名を取得
- String loginName = "";
- if (user != null) {
- loginName = user.getUsername();
- }
- model.addAttribute("username", loginName);
-
- City city = cityRepository.getById(citycode);
- model.addAttribute("citycode", citycode);
- model.addAttribute("cityname", city.getCityname());
- model.addAttribute("meshcode", meshcode);
-
- CitymeshPK pk = new CitymeshPK();
- pk.setCitycode(citycode);
- pk.setMeshcode(meshcode);
- Citymesh mesh = meshRepository.getById(pk);
-
- Task pre = service.getTaskByMesh(citycode, meshcode);
- if (pre != null) {
- pre.setOperation(Operation.RESERVE);
- pre.setUsername(loginName);
- model.addAttribute("task", pre);
- return "task";
- }
- else {
- // Taskが無い場合は生成する
- String uuid = UUID.randomUUID().toString();
- Task task = new Task();
- task.setCurrentId(uuid);
- task.setPreId(uuid);
- task.setCitycode(citycode);
- task.setMeshcode(meshcode);
- task.setMesh(mesh);
- task.setStatus(Status.PREPARATION);
- task.setUsername(loginName);
- task.setOperation(Operation.RESERVE);
- model.addAttribute("task", task);
- return "task";
- }
- }
-
- /**
- * 「タスク登録取り消し」
- * @param user
- * @param model
- * @param citycode
- * @param meshcode
- * @return
- */
- @GetMapping("/task/cancel")
- public String cancel(@AuthenticationPrincipal UserDetails user,
- Model model,
- @RequestParam(name="citycode") String citycode,
- @RequestParam(name="meshcode") String meshcode)
- {
- model.addAttribute("command", "タスク登録取消");
-
- // ログイン名を取得
- String loginName = "";
- if (user != null) {
- loginName = user.getUsername();
- }
- model.addAttribute("username", loginName);
-
- City city = cityRepository.getById(citycode);
- model.addAttribute("citycode", citycode);
- model.addAttribute("cityname", city.getCityname());
- model.addAttribute("meshcode", meshcode);
-
- CitymeshPK pk = new CitymeshPK();
- pk.setCitycode(citycode);
- pk.setMeshcode(meshcode);
- Citymesh mesh = meshRepository.getById(pk);
-
- Task pre = service.getTaskByMesh(citycode, meshcode);
- if (pre != null) {
- pre.setOperation(Operation.CANCEL);
- pre.setUsername(loginName);
- model.addAttribute("task", pre);
- return "task";
- }
- else {
- // Taskが無い場合は生成する
- String uuid = UUID.randomUUID().toString();
- Task task = new Task();
- task.setCurrentId(uuid);
- task.setPreId(uuid);
- task.setCitycode(citycode);
- task.setMeshcode(meshcode);
- task.setMesh(mesh);
- task.setStatus(Status.ACCEPTING);
- task.setUsername(loginName);
- task.setOperation(Operation.CANCEL);
- model.addAttribute("task", task);
-
- return "task";
- }
- }
/**
- * 「作業完了」
- * @param user
- * @param model
+ * 「タスク操作」
* @param citycode
* @param meshcode
+ * @param task
* @return
*/
- @GetMapping("/task/done")
- public String done(@AuthenticationPrincipal UserDetails user,
- Model model,
- @RequestParam(name="citycode") String citycode,
- @RequestParam(name="meshcode") String meshcode)
- {
- model.addAttribute("command", "作業終了");
-
- // ログイン名を取得
- String loginName = "";
- if (user != null) {
- loginName = user.getUsername();
- }
- model.addAttribute("username", loginName);
-
- City city = cityRepository.getById(citycode);
- model.addAttribute("citycode", citycode);
- model.addAttribute("cityname", city.getCityname());
- model.addAttribute("meshcode", meshcode);
-
- CitymeshPK pk = new CitymeshPK();
- pk.setCitycode(citycode);
- pk.setMeshcode(meshcode);
- Citymesh mesh = meshRepository.getById(pk);
-
- Task pre = service.getTaskByMesh(citycode, meshcode);
- if (pre != null) {
- pre.setOperation(Operation.DONE);
- pre.setUsername(loginName);
- model.addAttribute("task", pre);
- return "task";
- }
- else {
- // Taskが無い場合は生成する
- String uuid = UUID.randomUUID().toString();
- Task task = new Task();
- task.setCurrentId(uuid);
- task.setPreId(uuid);
- task.setCitycode(citycode);
- task.setMeshcode(meshcode);
- task.setMesh(mesh);
- task.setStatus(Status.IMPORTED);
- task.setUsername(loginName);
- task.setOperation(Operation.DONE);
- model.addAttribute("task", task);
- return "task";
- }
- }
-
@GetMapping("/task/add")
- public String addTask(
+ public String addTask(@AuthenticationPrincipal UserDetails user,
+ Model model,
+ @RequestParam(name="op") String op,
@RequestParam(name="citycode") String citycode,
- @RequestParam(name="meshcode") String meshcode,
- @ModelAttribute Task task)
+ @RequestParam(name="meshcode") String meshcode)
{
- return "task";
+ String next = "task";
+ Operation operation = Operation.NOP;
+ Status baseStatus = Status.PREPARATION;
+ if (op.equals(Operation.RESERVE.toString())) {
+ model.addAttribute("command", "タスク予約");
+ operation = Operation.RESERVE;
+ baseStatus = Status.PREPARATION;
+ }
+ else if (op.equals(Operation.CANCEL.toString())) {
+ model.addAttribute("command", "タスク予約取消");
+ operation = Operation.CANCEL;
+ baseStatus = Status.ACCEPTING;
+ }
+ else if (op.equals(Operation.DONE.toString())) {
+ model.addAttribute("command", "編集完了");
+ operation = Operation.DONE;
+ baseStatus = Status.IMPORTED;
+ next = "task_done";
+ }
+
+ // ログイン名を取得
+ String loginName = "";
+ if (user != null) {
+ loginName = user.getUsername();
+ }
+ model.addAttribute("username", loginName);
+
+ City city = cityRepository.getById(citycode);
+ model.addAttribute("citycode", citycode);
+ model.addAttribute("cityname", city.getCityname());
+ model.addAttribute("meshcode", meshcode);
+
+ CitymeshPK pk = new CitymeshPK();
+ pk.setCitycode(citycode);
+ pk.setMeshcode(meshcode);
+ Citymesh mesh = meshRepository.getById(pk);
+
+ Task pre = service.getTaskByMesh(citycode, meshcode);
+ if (pre != null) {
+ pre.setOperation(operation);
+ pre.setUsername(loginName);
+ model.addAttribute("task", pre);
+ return next;
+ }
+ else {
+ // 既存Taskが無い場合は生成する
+ String uuid = UUID.randomUUID().toString();
+ Task task = new Task();
+ task.setCurrentId(uuid);
+ task.setPreId(uuid);
+ task.setCitycode(citycode);
+ task.setMeshcode(meshcode);
+ task.setMesh(mesh);
+ task.setStatus(baseStatus);
+ task.setUsername(loginName);
+ task.setOperation(operation);
+ model.addAttribute("task", task);
+ return next;
+ }
}
@PostMapping("/task/process")
@@ -256,6 +150,9 @@
{
if (result.hasErrors()) {
// エラーがある場合
+ if (task.getOperation() == Operation.DONE) {
+ return "task_done";
+ }
return "task";
}
service.add(task, user);
@@ -264,6 +161,24 @@
}
/**
+ * 400 Bad Request
+ *
+ * @param e
+ * @param model
+ * @param citycode
+ * @param meshcode
+ * @return
+ */
+ @ExceptionHandler(TaskException.class)
+ public String taskExceptionHandler(TaskException e, Model model)
+ {
+ model.addAttribute("error", "400 Bad Request");
+ model.addAttribute("message", e.toString());
+ model.addAttribute("status", HttpStatus.BAD_REQUEST);
+ return exceptionHandler(e.getTask(), model);
+ }
+
+ /**
* 406 Not Acceptable
* "ACCEPTIONGではないため予約できません"
*
@@ -279,24 +194,7 @@
model.addAttribute("error", "406 Not Acceptable");
model.addAttribute("message", e.toString());
model.addAttribute("status", HttpStatus.NOT_ACCEPTABLE);
-
- Task task = e.getTask();
- if (task == null) {
- return "error";
- }
- if (task.getOperation() == Operation.RESERVE) {
- model.addAttribute("command", "タスク登録");
- }
- else if (task.getOperation() == Operation.CANCEL) {
- model.addAttribute("command", "タスク登録取消");
- }
- else if (task.getOperation() == Operation.DONE) {
- model.addAttribute("command", "作業完了");
- }
- model.addAttribute("citycode", task.getCitycode());
- model.addAttribute("meshcode", task.getMeshcode());
- model.addAttribute("task", task);
- return "task";
+ return exceptionHandler(e.getTask(), model);
}
/**
@@ -315,24 +213,30 @@
model.addAttribute("error", "409 Conflict");
model.addAttribute("message", e.toString());
model.addAttribute("status", HttpStatus.CONFLICT);
-
- Task task = e.getTask();
+ return exceptionHandler(e.getTask(), model);
+ }
+
+ private String exceptionHandler(Task task, Model model) {
if (task == null) {
return "error";
}
if (task.getOperation() == Operation.RESERVE) {
- model.addAttribute("command", "タスク登録");
+ model.addAttribute("command", "タスク予約");
}
else if (task.getOperation() == Operation.CANCEL) {
- model.addAttribute("command", "タスク登録取消");
+ model.addAttribute("command", "タスク予約取消");
}
else if (task.getOperation() == Operation.DONE) {
- model.addAttribute("command", "作業完了");
+ model.addAttribute("command", "編集済み");
}
model.addAttribute("citycode", task.getCitycode());
model.addAttribute("meshcode", task.getMeshcode());
model.addAttribute("task", task);
+
+ if (task.getOperation() == Operation.DONE) {
+ return "task_done";
+ }
return "task";
}
}
diff --git a/src/main/java/osm/surveyor/task/city/TaskService.java b/src/main/java/osm/surveyor/task/city/TaskService.java
index b0aa644..49eecad 100644
--- a/src/main/java/osm/surveyor/task/city/TaskService.java
+++ b/src/main/java/osm/surveyor/task/city/TaskService.java
@@ -62,34 +62,46 @@
}
if (task.getOperation() == Operation.RESERVE) {
if (ctask.getStatus() != Status.ACCEPTING) {
- NotAcceptableException e = new NotAcceptableException("ステータスがACCEPTIONGではないためタスク登録できませんでした : "+ task.getOperation());
+ NotAcceptableException e = new NotAcceptableException("ステータスがACCEPTIONGではないためタスク予約できませんでした : "+ task.getOperation());
e.setTask(task);
throw e;
}
}
else if (task.getOperation() == Operation.CANCEL) {
if (ctask.getStatus() != Status.RESERVED) {
- NotAcceptableException e = new NotAcceptableException("ステータスがRESERVEDではないためタスク登録できませんでした : "+ task.getOperation());
+ NotAcceptableException e = new NotAcceptableException("ステータスがRESERVEDではないため予約取消できませんでした : "+ task.getOperation());
e.setTask(task);
throw e;
}
if (!ctask.getUsername().equals(user.getUsername())) {
- NotAcceptableException e = new NotAcceptableException("他のマッパーのタスクはCANCELできません");
+ NotAcceptableException e = new NotAcceptableException("他のマッパーのタスク予約はCANCELできません");
e.setTask(task);
throw e;
}
}
else if (task.getOperation() == Operation.DONE) {
- if (ctask.getStatus() != Status.RESERVED) {
- NotAcceptableException e = new NotAcceptableException("タスク登録されていないためタスク完了できませんでした");
+ // タスク予約していなくてもインポートできる
+ // 他のマッパーが予約していてもインポート可能
+ String changeset = task.getChangeSet();
+ if (changeset == null) {
+ TaskException e = new TaskException("変更セットNoが入力されていません");
e.setTask(task);
throw e;
}
- if (!ctask.getUsername().equals(user.getUsername())) {
- NotAcceptableException e = new NotAcceptableException("他のマッパーのタスクは完了できません");
+ else if (changeset.isEmpty()) {
+ TaskException e = new TaskException("変更セットNoが入力されていません");
e.setTask(task);
throw e;
}
+ try {
+ Long.parseLong(changeset);
+ }
+ catch (NumberFormatException nfe) {
+ TaskException e = new TaskException("変更セットNoに数字以外の文字が入っています");
+ e.setTask(task);
+ throw e;
+ }
+
}
task.setPreId(ctask.getCurrentId());
task.setCurrentId(uuid);
diff --git a/src/main/resources/i18n/messages_ja.properties b/src/main/resources/i18n/messages_ja.properties
index ea165dc..655d648 100644
--- a/src/main/resources/i18n/messages_ja.properties
+++ b/src/main/resources/i18n/messages_ja.properties
@@ -29,7 +29,7 @@
# operation
download = ダウンロード
return = 戻る
-reserve = タスク登録
-cancel = 登録取消
+reserve = タスク予約
+cancel = タスク予約取消
confirm = 確定
done = 編集完了
diff --git a/src/main/resources/static/custom/meshes.js b/src/main/resources/static/custom/meshes.js
index 00f9178..bb61e02 100644
--- a/src/main/resources/static/custom/meshes.js
+++ b/src/main/resources/static/custom/meshes.js
@@ -105,7 +105,7 @@
var descriptionHTML =
"code: " + info.properties.id + "
" +
"version: " + info.properties.version + "
" +
- "";
+ "";
element.innerHTML = descriptionHTML;
__overlay.setPosition(coordinates);
__map.addOverlay(__overlay);
diff --git a/src/main/resources/static/custom/task.js b/src/main/resources/static/custom/task.js
index e44a9f8..47f7326 100644
--- a/src/main/resources/static/custom/task.js
+++ b/src/main/resources/static/custom/task.js
@@ -17,35 +17,3 @@
const citycode = queryObject['citycode'];
const meshcode = queryObject['meshcode'];
const op = queryObject['op'];
-
-function loadMap() {
- const div = document.getElementById("changeSet");
-
- const lab1 = document.createElement("label");
- lab1.setAttribute("for", "changeSet");
- lab1.setAttribute("th:text", "#{changeSet}");
-
- const inp1 = document.createElement("input");
- inp1.setAttribute("type", "text");
- inp1.setAttribute("class", "form-control");
- inp1.setAttribute("th:errorclass", "is-invalid");
- inp1.setAttribute("th:field", "*{changeSet}");
-
- const d1 = document.createElement("div");
- d1.setAttribute("class", "invalid-feedback");
- d1.setAttribute("th:errors", "*{changeSet}");
-
- const inp2 = document.createElement("input");
- inp2.setAttribute("type", "hidden");
- inp2.setAttribute("th:field", "*{changeSet}");
- inp2.setAttribute("th:value", "*{changeSet}");
-
- if (op == "DONE") {
- div.appendChild(lab1);
- div.appendChild(inp1);
- div.appendChild(d1);
- }
- else {
- div.appendChild(inp2);
- }
-}
diff --git a/src/main/resources/templates/task.html b/src/main/resources/templates/task.html
index d975428..13f8ec4 100644
--- a/src/main/resources/templates/task.html
+++ b/src/main/resources/templates/task.html
@@ -6,9 +6,8 @@
-
-
+